Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the project’s JavaScript/TypeScript linting from ESLint to oxlint, updating config and adjusting code to satisfy the new linter rules across the SvelteKit/Tauri codebase.
Changes:
- Replace ESLint with oxlint (new
oxlint.config.ts, updatedpackage.jsonscripts/devDependencies, removeeslint.config.js). - Mechanical refactors for lint compliance (e.g.,
sort()→toSorted(), addthis: voidwhere needed). - Minor config/key reordering in Vite/Svelte config files.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.js |
Reorders config and keeps build.target: "esnext"/clearScreen in a new position. |
svelte.config.js |
Reorders preprocess within the config object. |
src/routes/settings/+page.svelte |
Uses toSorted() for category ordering. |
src/lib/split-layout.ts |
Uses toSorted() for candidate scoring without mutation. |
src/lib/models/message/user-message.ts |
Uses toSorted() in cached sorting paths. |
src/lib/models/badge.ts |
Adds this: void to a static method signature. |
src/lib/components/ChannelList.svelte |
Uses toSorted() in derived sorting/grouping logic. |
src/lib/completer.svelte.ts |
Uses toSorted() when sorting completion results. |
src/lib/commands/twitch/vips.ts |
Switches to toSorted() for VIP list output. |
src/lib/commands/twitch/unban.ts |
Adds this: void to exec signature. |
src/lib/commands/twitch/mods.ts |
Switches to toSorted() for moderator list output. |
src/lib/commands/built-in/founders.ts |
Switches to toSorted() for founders list output. |
package.json |
Updates lint scripts and replaces ESLint deps with oxlint deps. |
oxlint.config.ts |
Adds oxlint configuration (categories/options/rules). |
eslint.config.js |
Removes the old ESLint configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| user?.vips?.edges | ||
| ?.flatMap((edge) => (edge.node ? [edge.node.displayName] : [])) | ||
| .sort() ?? []; | ||
| .toSorted() ?? []; |
Comment on lines
14
to
+17
| const founders = | ||
| user?.channel?.founders | ||
| ?.flatMap((founder) => (founder?.user ? [founder.user.displayName] : [])) | ||
| .sort() ?? []; | ||
| .toSorted() ?? []; |
Comment on lines
14
to
+17
| const mods = | ||
| user?.mods?.edges | ||
| .flatMap((edge) => (edge.node ? [edge.node.displayName] : [])) | ||
| .sort() ?? []; | ||
| .toSorted() ?? []; |
| "no-control-regex": "allow", | ||
| "typescript/adjacent-overload-signatures": "error", | ||
| "typescript/no-floating-promises": "allow", | ||
| "unicorn/filename-case": ["error", { ignore: ".*\\.svelte$" }], |
Comment on lines
+69
to
+70
| "oxlint": "^1.56.0", | ||
| "oxlint-tsgolint": "^0.17.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.